Questions tagged [code-review]

Code review is systematic examination of your Arduino sketch. It is intended to find and fix mistakes overlooked in the initial development phase, improving both the overall quality of software and the developers' skills.

Filter by
Sorted by
Tagged with
1 vote
0 answers
35 views

Code question: LCD keypad Shield. How do I define the buttons?

I am trying to adapt a alarm clock sketch that used external buttons, but I would like to utilize a LCD Keypad Shield. The data sheet says all the buttons are on pin A0, so every button is "set ...
user avatar
-1 votes
1 answer
42 views

Displaying multiple temperature outputs w/Thermistors

So I asked this question a couple days ago but did some more work with some of the coding, but I'm really stuck and need some help. I'm trying to display the temperature for each separate thermistor ...
user avatar
3 votes
0 answers
132 views

Integration of MAX30100 and DS18B20 Thermal Probe Integration

This is for my final year project that I have been tasked with designing a patient monitoring system. However, during the last stretch of model prototyping, I am experiencing issues with my MAX30100 ...
user avatar
1 vote
1 answer
50 views

I am trying to add a countdown to my Arduino code but it does 0 days, 04:09:36 instead of starting at 7 days

The code I use probably has a math problem since an Arduino can only count a 16 bit integer. This problem is with the WeekDelay() function. The project is for an Aerogarden. It pumps water into the ...
user avatar
1 vote
0 answers
42 views

RFM69 Sending Failure

Hi I'm trying to get the RFM69 rf module to work on an arduino uno. Here is my code: #include <SPI.h> // Addresses for this node. CHANGE THESE FOR EACH NODE! #define NETWORKID 0 // Must be ...
user avatar
  • 21
-1 votes
1 answer
120 views

I have been having a lot of trouble adding a countdown to a piece of code [closed]

This is the code. The /// are where I added the countdown. Unfortunately the countdown only goes down 9 seconds. What I want it to do is go down the full 24 hours. I have been trying to fix this error ...
user avatar
1 vote
0 answers
25 views

servos act strangely instead of stopping/starting

I am trying to make it so that my robot rolls straight when pin 8 is high and stop when pin 8 is low, the 2 servos is constant rotation servos. instead the servos spin when the wire touches it pin ...
user avatar
  • 11
-1 votes
1 answer
37 views

'for loop' seems to change the execution of pow()

The first time, pow() works. But inside of a 'for loop', or again afterwards, it doesn't behave !? (I'm using a Chinese Pro Mini with Arduino 1.8.16) EDIT To clarify what I am asking, my question is:...
user avatar
  • 21
0 votes
1 answer
71 views

Two-Wire Interface (TWI) Frequency and SMBus Compatibility

Have I understood the ATmega328P datasheet correctly regarding the TWI clock frequency? From §21.5.2 Bit Rate Generator Unit, the TWI clock frequency is calculated as follows: Then solving for TWBR: ...
user avatar
  • 629
5 votes
3 answers
882 views

How do I make another action repeat inside a loop?

So, I've just started programming Arduino (and also in general), so I'm doing basic things, like switching on and off LED's. I've made them light in a sequence and then turning them off (in the same ...
user avatar
1 vote
2 answers
106 views

Unwanted ghosting with charlieplexed LEDs

I have a very simple PCB that uses 3 GPIO on a ATtiny85 to control 6 LEDs using charlieplexing. When I try to program certain patterns of lit LEDs (pseudo PWM) I get some LEDs lighting dimly when they ...
user avatar
1 vote
2 answers
148 views

NodeMCU wont connect to Blynk

My NodeMCU wont connect to Blynk with my code but works fine with example code and same auth token and WiFi info. Cant figure out why its not working. Must be something in my code interfering with it (...
user avatar
0 votes
1 answer
299 views

HX711 Ridiculous speeds

I'm using a SparkFun HX711 board and an Adafruit AdaLogger (M0) Featherboard. I have cut the trace on the back of the HX711 to get a faster data rate (should be about 80 sps). I did this by reviewing ...
user avatar
  • 134
2 votes
2 answers
131 views

How to get 2 loop functions to cooperate?

I have a OLED SSD1306 & DS3231 RTC, 2 buttons to set the time & date. My project is to display a scrolling text at the top of the OLED, the RTC time in the middle, the day & date on the ...
user avatar
1 vote
0 answers
94 views

Project doesn't work after 2 - 3 times, requires frequent turning off and on

I am new to Arduino and I am working on a project. This project inspired me and I tried doing it. The following code was provided in the description: int maxPeople = 5; // maximum number of people ...
user avatar
  • 113
1 vote
2 answers
258 views

Arduino code not working properly (Please Help)

I am having some trouble getting my board to perform the function I want it to perform. This is a project I have due in a few days, and I have hit a wall I just can't seem to get past. Now, I will say ...
user avatar
  • 13
1 vote
1 answer
696 views

Multiple Wire.write() not working for Arduino Nano I2C

Code for Master #include <Wire.h> void setup() { Wire.begin(); Serial.begin(9600); } void loop() { Wire.beginTransmission(9); Wire.write('c'); Serial....
user avatar
  • 11
1 vote
2 answers
91 views

Adding another flow sensor to sketch

Adding another flow sensor to sketch I have a water flow sketch I use for my freshwater consumption. I would like to adapt it to use for diesel fuel consumption. The difference is with a diesel ...
user avatar
1 vote
1 answer
113 views

Make an LED Turn

//Make an LED Turn ON after pressing a push button switch for five times. Add a reset switch to turn OFF the LED whenever the reset switch is pressed **void setup() { pinMode(11, OUTPUT); ...
user avatar
1 vote
1 answer
48 views

Explanation of code found online

i found following code online, to read the value of a touch sensor... i am having difficulties understanding how the 2 second timeout on the marked line works.. if ((touch_sensor_value (...
user avatar
1 vote
0 answers
202 views

U-blox GPS module (and TinyGPS library): altitude data getting stuck at strange values

We have built a HAB (high-altitude balloon) tracker based on an Arduino and a U-blox GPS module, but we have a sporadic issue where the altitude data gets stuck at odd (usually low) values. The ...
user avatar
  • 11
1 vote
0 answers
151 views

How to stop my 16*2 lcd blink?

Here I wrote code for my weighting scale measurement. In which I added an on/off switch for my LCD display. But in defined delay time my LCD is a blink and I do not want it. I want my LCD switch on/...
user avatar
2 votes
0 answers
50 views

Am I maximising my A0 readout rate with this peak-detection code?

I have a pulse going into A0 on a Nano, and want to detect the peak voltage. With low-pass filtering to slow down the input pulse I'm still reading marginally too slow. The code overall inhibits a ...
user avatar
  • 146
1 vote
1 answer
420 views

ESP32 preferences. One error returned, all others work. SOLVED

I am using the Preferences.h library in my Arduino code. I initialize some values. I save them with the preference library. I then modify all the values, then read back the original saved values. All ...
user avatar
  • 985
2 votes
0 answers
1k views

Node MCU code is stuck in while (WiFi.status() != WL_CONNECTED) [closed]

I am using the Node MCu V3 board ESP8266MOD Board Manager Version: 2.7.4 Arduino IDE: 1.8.12 My code is stuck in the while (WiFi.status() != WL_CONNECTED) Here is code: #include <ESP8266WiFi.h> ...
user avatar
1 vote
0 answers
505 views

Wemos d1 mini code not uploading

I have a wemos d1 mini. I uploaded a code in wemos d1 mini and after that my wemos mini not working. I tried to upload another code in it even the led blink sketch and even a blank sketch but whenever ...
user avatar
1 vote
1 answer
326 views

How to add two assembly arrays in arduino

Hey guys what I'm trying to do is to sum two arrays and return a new array; for example if given uint8_t a[] = {2, 4, 6}; uint8_t b[] = {1, 2, 3}; I should get { 3, 6, 9} What I'm trying to do is ...
user avatar
3 votes
2 answers
1k views

How to move a servo quickly and without delay function

Im trying to move a servo from one place to another while using the typical for loop you find in the servo's library example. int lightON = 180; int lightOFF = 90; for (pos1 = lightOFF; pos1 <= ...
user avatar
  • 111
3 votes
2 answers
105 views

How to move a servo with a function

Im currently moving a servo from one side to another by using the typical for loop like this: int lightON = 180; int lightOFF = 90; if (buttonState == HIGH) { digitalWrite(LED, HIGH); for (pos1 =...
user avatar
  • 111
1 vote
1 answer
82 views

Turning on and off two set of LEDs with two tactile buttons

I have two sets of 4 LEDs. Set A (Led1 Led2, Led3, Led4) Set B (Led5 Led6, Led7, Led8) Both sets have its own tactile button: Tactile A, Tactile B, Tactile A, turning on the LEDs set A and tactile B ...
user avatar
1 vote
1 answer
285 views

How to override automatic control in Blynk app?

I am a beginner to Blynk, and have successfully built a simple water temperature control project. It consists of ESP32, a plug-in water heater, and an AC relay board. The ESP32 controls the relay ...
user avatar
1 vote
0 answers
129 views

Why is my buzzer always on?

I wanted to make a buzzer go off when the distance measured by the ultrasonic sensor becomes more than 100cm. The things used in this project are a 4x4 keypad, an hc-sr04 ultrasonic sensor, and a ...
user avatar
  • 31
2 votes
1 answer
59 views

File created, but not logging data

I am starting using Arduino and have very little to none experience coding. However, I have managed to code and understand how it works. The problem that I have is that I am unable to log (record) ...
user avatar
1 vote
0 answers
47 views

Can someone check my schematic and code? My Led is not turning on

Led1 is on the left Led2 is on the right The code is making LED1 blink every second but it should also turn on Led2 so that whenever I press the push button it should turn off Led2. But Led2 isn't ...
user avatar
1 vote
0 answers
49 views

Automatic water pump Trigger System - I need my code FIXED

int out = LED_BUILTIN; int strt = 3; int stp = 9; void setup() { pinMode(out,OUTPUT); pinMode(strt,INPUT); pinMode(stp,INPUT); } void loop() { while(true) { if(digitalRead(strt) == LOW) ...
user avatar
0 votes
1 answer
46 views

How might I add a delay, close the servo and go to the start again?

#include <Servo.h> Servo myServo; const int piezo = A0; const int button = 2; const int yellow = 3; const int green = 4; const int red = 5; int knockVal; int buttonVal; const ...
user avatar
2 votes
0 answers
117 views

Please help with my tinkercad code. Debouncing stopwatch with lcd

#include <LiquidCrystal.h> LiquidCrystal lcd(12, 11, 5, 4, 3, 2); int ssPin = 8; int resetPin = 9; bool cntrRunning = false; int sec = 0; int min = 0; double currentMillis; void setup() { ...
user avatar
  • 21
1 vote
1 answer
173 views

Esp32 not connect with WiFi

I'm trying to connect WiFi at home in my esp32 but in the serial monitor shows a looping connecting to WiFi but never connect. look this The link that I followed. To my application. I want to connect ...
user avatar
2 votes
1 answer
367 views

Measure Vcc on ATtiny13a?

I am trying to figure out if I can measure the Vcc of attiny13a, but the code I use for arduino's and attiny85 does not work. This is where I got the code from. I know that it works by using the 1.1v ...
user avatar
1 vote
1 answer
153 views

Help in personal alarm clock project, cant write time on seven segment display

I'm trying to make a type of Arduino alarm clock, which when the time I inputed is equals to the current time, a servo will turn on my lights. It basically consists of a Keypad, an RTC DS1307 and a ...
user avatar
  • 111
1 vote
4 answers
94 views

Why does the following code not cause the led's to flash but rather stay on continuously

int timer = 1000; int thispin = 5; void setup() { for (int thispin = 5; thispin < 8; thispin++) pinMode(thispin, OUTPUT); } void loop() { for (int thispin = 5; thispin < 8; thispin++) ...
user avatar
  • 11
1 vote
1 answer
277 views

Understanding Debounce code

I don't understand the following Debounce code. (The complete code is at the bottom.) From what I understand, when the pin reads something, we wait at least 50 milliseconds before performing anything. ...
user avatar
-2 votes
0 answers
98 views

Code for fish auto feeder not working [duplicate]

I've been trying to make this code work, but for some reason, it doesn't work for me, even if I do everything like in the tutorial. So I've tried to do a new code and the outcome was the same. The ...
user avatar
1 vote
0 answers
78 views

Help with code not working

I built a button box, everything is wired up and all of the push buttons work using the code below, but for some reason my rotary encoders are not working, well 3 out of the 4 are not working. Is ...
user avatar
  • 21
0 votes
1 answer
1k views

I get an error saying, "exit status 1 expected initializer before 'void'." [closed]

I will be wiring a switch to the Arduino that controls the voltage. When the I turn the switch it can adjust the voltage from 0 to 5. The overall task is to print the output voltage. The print is to ...
user avatar
  • 9
1 vote
1 answer
126 views

FOR Statement Within IF Statement

The past few days I've had trouble with a FOR loop iteration within an IF statement. I have a 12V DC geared motor with magnetic encoder being driven by an L298N motor driver which is controlled by an ...
user avatar
1 vote
3 answers
1k views

Why are the Do While loops not stopping?

Ive been staring at this for a while now and I am going cross-eyed. I am writing a simply program to change colors of a 3 color LED. It is working, but then I noticed the LED would sometimes flash. ...
user avatar
  • 163
3 votes
1 answer
712 views

Why is this looping?

I am trying to do something very simple. I want the LED to fade from full brightness to off. This works... However, the LED turns back on to full brightness and fades again, in a loop. I am not ...
user avatar
  • 163
1 vote
0 answers
152 views

ESP32-POE/ISO unstable after 10 days of power up

i have one ESP32-POE and ESP32-POE and i'm using the Olimex RS485 module to read a power meter that is placed near the ESP32 (5 meters of CAT5 cable - 9600 8N1). My device has this workflow (it's ...
user avatar
  • 147
1 vote
1 answer
131 views

inconsistent digital output on simple code

so im new on arduino coding, and i made this code, where i input from serial monitor and then use it as a command for digital write. the problem is, sometimes the code work perfectly but then when i ...
user avatar

1
2 3 4 5